arphaman added a comment.
In https://reviews.llvm.org/D37856#894638, @hokein wrote:
> Sorry for the delay. I saw you have reverted this commit somehow. A post
> commit.
I had some issues with ppc64/s390x bots for some reason, so I had to revert.
I'm still trying to investigate what went wrong there, it looks like ASAN/UBSAN
are not catching anything though.
================
Comment at: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp:113
Rules.push_back(createRefactoringActionRule<RenameOccurrences>(
- SymbolSelectionRequirement()));
+ SymbolSelectionRequirement(), OptionRequirement<NewNameOption>()));
return Rules;
----------------
hokein wrote:
> Thought it a bit more: it requires all of the requirements are satisfied, I
> think we need to support "one-of" option. For example, we have two option
> "-a" and "-b", only one of them is allowed to be present at the same time.
That should be straightforward enough to implement, either with a custom class
or with a built-in requirement class. I'll probably add a builtin one when the
need comes up.
Repository:
rL LLVM
https://reviews.llvm.org/D37856
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
