github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h --
clang/include/clang/AST/DeclCXX.h clang/include/clang/Sema/Sema.h
clang/lib/CodeGen/MicrosoftCXXABI.cpp clang/lib/Sema/SemaDecl.cpp
clang/lib/Sema/SemaDeclCXX.cpp clang/lib/Sema/SemaExprCXX.cpp
clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
clang/lib/Serialization/ASTReaderDecl.cpp
clang/lib/Serialization/ASTWriterDecl.cpp
clang/test/CodeGenCXX/dllexport-ctor-closure.cpp
clang/test/CodeGenCXX/microsoft-abi-throw.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/include/clang/AST/DeclCXX.h
b/clang/include/clang/AST/DeclCXX.h
index e22881556..0d1c270e4 100644
--- a/clang/include/clang/AST/DeclCXX.h
+++ b/clang/include/clang/AST/DeclCXX.h
@@ -2671,7 +2671,9 @@ public:
// FIXME: Just hacking it in here for now.
Expr **CtorClosureArgs = nullptr;
Expr **ctorClosureArgs() const { return getCanonicalDecl()->CtorClosureArgs;
}
- void setCtorClosureArgs(Expr **Args) { getCanonicalDecl()->CtorClosureArgs =
Args; }
+ void setCtorClosureArgs(Expr **Args) {
+ getCanonicalDecl()->CtorClosureArgs = Args;
+ }
static CXXConstructorDecl *CreateDeserialized(ASTContext &C, GlobalDeclID ID,
uint64_t AllocKind);
diff --git a/clang/include/clang/Sema/Sema.h b/clang/include/clang/Sema/Sema.h
index 84a124aa0..3b046f95d 100644
--- a/clang/include/clang/Sema/Sema.h
+++ b/clang/include/clang/Sema/Sema.h
@@ -14266,7 +14266,9 @@ public:
LocalInstantiationScope *OuterMostScope = nullptr);
/// XXX: comment
- bool BuildDefaultArgsForCtorClosure(SourceLocation Loc, CXXConstructorDecl
*Ctor, bool IsCopy = false);
+ bool BuildDefaultArgsForCtorClosure(SourceLocation Loc,
+ CXXConstructorDecl *Ctor,
+ bool IsCopy = false);
bool InstantiateDefaultArgument(SourceLocation CallLoc, FunctionDecl *FD,
ParmVarDecl *Param);
diff --git a/clang/lib/CodeGen/MicrosoftCXXABI.cpp
b/clang/lib/CodeGen/MicrosoftCXXABI.cpp
index 3de3fd8cb..4701de6c6 100644
--- a/clang/lib/CodeGen/MicrosoftCXXABI.cpp
+++ b/clang/lib/CodeGen/MicrosoftCXXABI.cpp
@@ -4207,11 +4207,11 @@ MicrosoftCXXABI::getAddrOfCXXCtorClosure(const
CXXConstructorDecl *CD,
if (SrcVal)
Args.add(RValue::get(SrcVal), SrcParam->getType());
-
// Add the rest of the default arguments.
SmallVector<const Stmt *, 4> ArgVec;
for (unsigned I = IsCopy ? 1 : 0, N = CD->getNumParams(); I != N; ++I) {
- assert(CD->getParamDecl(I)->hasDefaultArg() && "ctor closure lacks default
args");
+ assert(CD->getParamDecl(I)->hasDefaultArg() &&
+ "ctor closure lacks default args");
assert(CD->ctorClosureArgs());
ArgVec.push_back(CD->ctorClosureArgs()[I]);
}
diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp
index e7a96ad1f..d9caec0bc 100644
--- a/clang/lib/Sema/SemaDeclCXX.cpp
+++ b/clang/lib/Sema/SemaDeclCXX.cpp
@@ -6339,7 +6339,8 @@ static void ReferenceDllExportedMembers(Sema &S,
CXXRecordDecl *Class) {
if (S.Context.getTargetInfo().getCXXABI().isMicrosoft()) {
auto *CD = dyn_cast<CXXConstructorDecl>(MD);
if (CD && CD->isDefaultConstructor() && TSK == TSK_Undeclared) {
-
S.BuildDefaultArgsForCtorClosure(CD->getAttr<DLLExportAttr>()->getLocation(),
CD);
+ S.BuildDefaultArgsForCtorClosure(
+ CD->getAttr<DLLExportAttr>()->getLocation(), CD);
}
}
@@ -19803,7 +19804,9 @@ void
Sema::ActOnFinishFunctionDeclarationDeclarator(Declarator &Declarator) {
InventedParameterInfos.pop_back();
}
-bool Sema::BuildDefaultArgsForCtorClosure(SourceLocation Loc,
CXXConstructorDecl *Ctor, bool IsCopy) {
+bool Sema::BuildDefaultArgsForCtorClosure(SourceLocation Loc,
+ CXXConstructorDecl *Ctor,
+ bool IsCopy) {
assert(Context.getTargetInfo().getCXXABI().isMicrosoft());
if (Ctor->ctorClosureArgs())
@@ -19814,7 +19817,7 @@ bool
Sema::BuildDefaultArgsForCtorClosure(SourceLocation Loc, CXXConstructorDecl
return false;
unsigned FirstParam = IsCopy ? 1 : 0;
- Expr **Args = new (getASTContext()) Expr*[NumParams];
+ Expr **Args = new (getASTContext()) Expr *[NumParams];
Args[0] = nullptr;
for (unsigned I = FirstParam; I != NumParams; ++I) {
diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp
index 59e69314c..03ef3da6a 100644
--- a/clang/lib/Sema/SemaExprCXX.cpp
+++ b/clang/lib/Sema/SemaExprCXX.cpp
@@ -1070,7 +1070,8 @@ bool Sema::CheckCXXThrowOperand(SourceLocation ThrowLoc,
// We don't keep the instantiated default argument expressions around so
// we must rebuild them here.
- // XXX: surprisingly, CD->isCopyConstructor() is not necessarily true
here!
+ // XXX: surprisingly, CD->isCopyConstructor() is not necessarily true
+ // here!
if (BuildDefaultArgsForCtorClosure(ThrowLoc, CD, /*IsCopy=*/true))
return true;
}
diff --git a/clang/lib/Serialization/ASTReaderDecl.cpp
b/clang/lib/Serialization/ASTReaderDecl.cpp
index 8250b5bde..5e6bb2552 100644
--- a/clang/lib/Serialization/ASTReaderDecl.cpp
+++ b/clang/lib/Serialization/ASTReaderDecl.cpp
@@ -2334,7 +2334,7 @@ void
ASTDeclReader::VisitCXXConstructorDecl(CXXConstructorDecl *D) {
InheritedConstructor(Shadow, Ctor);
}
if (int NumCtorClosureArgs = Record.readInt()) {
- Expr **Args = new (Reader.getContext()) Expr*[NumCtorClosureArgs];
+ Expr **Args = new (Reader.getContext()) Expr *[NumCtorClosureArgs];
for (int I = 0; I != NumCtorClosureArgs; I++)
Args[I] = cast<Expr>(Record.readStmt());
D->setCtorClosureArgs(Args);
``````````
</details>
https://github.com/llvm/llvm-project/pull/203554
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
