NoQ added a comment.
Ideas behind both hashing change and new testing mechanism look great to me.
I think it would be great to split them into two different patches, to be able
to easily see how the change in the hashing affects the tests (and maybe revert
easily if something goes wrong).
================
Comment at: lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:88
+ &ExprInspectionChecker::analyzerNumTimesReached)
+ .Case("clang_analyzer_hash_dump",
+ &ExprInspectionChecker::analyzerDumpHash)
----------------
`clang_analyzer_hashDump` would be more consistent.
https://reviews.llvm.org/D38728
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
