================
@@ -949,7 +958,20 @@ static mlir::Value emitCommonNeonBuiltinExpr(
   case NEON::BI__builtin_neon_vshlq_n_v:
     return emitCommonNeonShift(cgf.getBuilder(), loc, vTy, ops[0], ops[1],
                                /*shiftLeft=*/true);
-  case NEON::BI__builtin_neon_vshll_n_v:
+  case NEON::BI__builtin_neon_vshll_n_v: {
----------------
iamvickynguyen wrote:

Interestingly, `vaddl/vaddw` need both `vmovl` and `vshll`. We can see `vmovl` 
in the tests, but `vshll` is quite hidden 😄

Here is the trace:

https://github.com/llvm/llvm-project/blob/16d22173dbb1d3e77cfed5bbcc2aca1157350d25/clang/include/clang/Basic/arm_neon.td#L992

https://github.com/llvm/llvm-project/blob/16d22173dbb1d3e77cfed5bbcc2aca1157350d25/clang/include/clang/Basic/arm_neon.td#L18

https://github.com/llvm/llvm-project/blob/16d22173dbb1d3e77cfed5bbcc2aca1157350d25/clang/include/clang/Basic/arm_neon.td#L981

https://github.com/llvm/llvm-project/blob/16d22173dbb1d3e77cfed5bbcc2aca1157350d25/clang/include/clang/Basic/arm_neon.td#L162-L164

https://github.com/llvm/llvm-project/pull/204285
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to