[PATCH] D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests

[Michał Górny via Phabricator via cfe-commits]

mgorny updated this revision to Diff 118826.
mgorny retitled this revision from "[compiler-rt] [cmake] [asan] Reuse 
generate_asan_tests for dynamic tests" to "[compiler-rt] [cmake] [asan] Remove 
unnecessary gtest dep from dynamic tests".
mgorny edited the summary of this revision.
mgorny added a comment.

Ok, here's another idea. Since the objects have been compiled already (and they 
explicitly depend on gtest via their own deps), let's just remove the 
extraneous gtest dep.


https://reviews.llvm.org/D38840

Files:
  lib/asan/tests/CMakeLists.txt


Index: lib/asan/tests/CMakeLists.txt
===================================================================
--- lib/asan/tests/CMakeLists.txt
+++ lib/asan/tests/CMakeLists.txt
@@ -205,7 +205,7 @@
       add_compiler_rt_test(AsanDynamicUnitTests "${dynamic_test_name}" 
"${arch}"
         SUBDIR "dynamic"
         OBJECTS ${ASAN_INST_TEST_OBJECTS}
-        DEPS gtest asan ${ASAN_INST_TEST_OBJECTS}
+        DEPS asan ${ASAN_INST_TEST_OBJECTS}
         LINK_FLAGS ${ASAN_DYNAMIC_UNITTEST_INSTRUMENTED_LINK_FLAGS}
         )
     endif()



Index: lib/asan/tests/CMakeLists.txt
===================================================================
--- lib/asan/tests/CMakeLists.txt
+++ lib/asan/tests/CMakeLists.txt
@@ -205,7 +205,7 @@
       add_compiler_rt_test(AsanDynamicUnitTests "${dynamic_test_name}" "${arch}"
         SUBDIR "dynamic"
         OBJECTS ${ASAN_INST_TEST_OBJECTS}
-        DEPS gtest asan ${ASAN_INST_TEST_OBJECTS}
+        DEPS asan ${ASAN_INST_TEST_OBJECTS}
         LINK_FLAGS ${ASAN_DYNAMIC_UNITTEST_INSTRUMENTED_LINK_FLAGS}
         )
     endif()

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits