https://github.com/ilovepi commented:

Another issue I see is that this PR has too much going on. I'd split this up 
and simplify it as much as possible. I'm also quite concerned about many 
aspects of the implementation, and the general direction I see this heading.

I'm also increasingly concerned that you do not know how this code works or 
have a sense of its overall design.

https://github.com/llvm/llvm-project/pull/202991
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to