================
@@ -9666,6 +9665,18 @@ def dxc_Zss : DXCFlag<"Zss">,
               HelpText<"Compute Shader Hash considering source information">;
 def dxc_Zsb : DXCFlag<"Zsb">,
               HelpText<"Compute Shader Hash considering only output binary">;
+def dxc_Fd
+    : DXCJoinedOrSeparate<"Fd">,
+      HelpText<"Write debug information to the given file, or automatically "
+               "named file in directory when ending in '/'">;
+def dxc_Qembed_debug
+    : DXCFlag<"Qembed_debug">,
+      HelpText<"Embed PDB in shader container (must be used with /Zi)">;
+def dxc_Zi : Option<["/", "-"], "Zi", KIND_FLAG>,
+             Group<dxc_Group>,
+             Alias<g_Flag>,
+             Visibility<[CLOption, DXCOption]>,
+             HelpText<"Enable debug information">;
----------------
bogner wrote:

This doesn't seem right:
- _SLASH_Zi was already an alias for g_Flag, and available for DXC
- Putting this in dxc_Group isn't great, because it causes `clang-cl` to now 
emit this as a "dxc compatibility option" instead of a "cl.exe compatibility" 
one. This is just confusing.

I think all we actually want to do with Zi is update the help text from "Like 
/Z7" to "Enable debug information", since that's meaningful and correct for 
both cl and dxc driver modes.

https://github.com/llvm/llvm-project/pull/204166
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to