arichardson added inline comments.
================
Comment at: lib/AST/TypePrinter.cpp:1323
OS << "address_space(";
- OS << T->getEquivalentType().getAddressSpace();
+ OS << T->getEquivalentType()
+ .getQualifiers()
----------------
Anastasia wrote:
> arichardson wrote:
> > Anastasia wrote:
> > > Why do we need this change?
> > `__attribute__((address_space(n)))` is a target address space and not a
> > language address space like `LangAS::opencl_generic`. Isn't
> > `Qualifiers::getAddressSpaceAttributePrintValue()` meant exactly for this
> > use case?
> Yes, I think there are some adjustment we do in this method to get the
> original source value to be printed corerctly. Does this mean we have no
> tests that caught this issue?
Seems like it, all tests pass both with and without this patch.
https://reviews.llvm.org/D38816
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
