github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp --
clang/include/clang/Analysis/Analyses/LifetimeSafety/LifetimeSafety.h
clang/lib/Analysis/LifetimeSafety/Checker.cpp
clang/lib/Sema/SemaLifetimeSafety.h
clang/test/Sema/LifetimeSafety/invalidations.cpp
clang/test/Sema/LifetimeSafety/safety.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git
a/clang/include/clang/Analysis/Analyses/LifetimeSafety/LifetimeSafety.h
b/clang/include/clang/Analysis/Analyses/LifetimeSafety/LifetimeSafety.h
index 3e03de134..4e2412b17 100644
--- a/clang/include/clang/Analysis/Analyses/LifetimeSafety/LifetimeSafety.h
+++ b/clang/include/clang/Analysis/Analyses/LifetimeSafety/LifetimeSafety.h
@@ -83,36 +83,30 @@ public:
// Reports when a reference/iterator is used after the container operation
// that invalidated it.
- virtual void reportUseAfterInvalidation(const Expr *IssueExpr,
- const Expr *UseExpr,
- const Expr *InvalidationExpr,
- const internal::AccessPath
- &InvalidatedPath) {}
- virtual void reportUseAfterInvalidation(const ParmVarDecl *PVD,
- const Expr *UseExpr,
- const Expr *InvalidationExpr,
- const internal::AccessPath
- &InvalidatedPath) {}
- virtual void reportInvalidatedField(const Expr *IssueExpr,
- const FieldDecl *Field,
- const Expr *InvalidationExpr,
- const internal::AccessPath
- &InvalidatedPath) {}
- virtual void reportInvalidatedField(const ParmVarDecl *PVD,
- const FieldDecl *Field,
- const Expr *InvalidationExpr,
- const internal::AccessPath
- &InvalidatedPath) {}
- virtual void reportInvalidatedGlobal(const Expr *IssueExpr,
- const VarDecl *Global,
- const Expr *InvalidationExpr,
- const internal::AccessPath
- &InvalidatedPath) {}
- virtual void reportInvalidatedGlobal(const ParmVarDecl *PVD,
- const VarDecl *Global,
- const Expr *InvalidationExpr,
- const internal::AccessPath
- &InvalidatedPath) {}
+ virtual void
+ reportUseAfterInvalidation(const Expr *IssueExpr, const Expr *UseExpr,
+ const Expr *InvalidationExpr,
+ const internal::AccessPath &InvalidatedPath) {}
+ virtual void
+ reportUseAfterInvalidation(const ParmVarDecl *PVD, const Expr *UseExpr,
+ const Expr *InvalidationExpr,
+ const internal::AccessPath &InvalidatedPath) {}
+ virtual void
+ reportInvalidatedField(const Expr *IssueExpr, const FieldDecl *Field,
+ const Expr *InvalidationExpr,
+ const internal::AccessPath &InvalidatedPath) {}
+ virtual void
+ reportInvalidatedField(const ParmVarDecl *PVD, const FieldDecl *Field,
+ const Expr *InvalidationExpr,
+ const internal::AccessPath &InvalidatedPath) {}
+ virtual void
+ reportInvalidatedGlobal(const Expr *IssueExpr, const VarDecl *Global,
+ const Expr *InvalidationExpr,
+ const internal::AccessPath &InvalidatedPath) {}
+ virtual void
+ reportInvalidatedGlobal(const ParmVarDecl *PVD, const VarDecl *Global,
+ const Expr *InvalidationExpr,
+ const internal::AccessPath &InvalidatedPath) {}
using EscapingTarget =
llvm::PointerUnion<const Expr *, const FieldDecl *, const VarDecl *>;
diff --git a/clang/lib/Analysis/LifetimeSafety/Checker.cpp
b/clang/lib/Analysis/LifetimeSafety/Checker.cpp
index 4c6542599..ac20e83c8 100644
--- a/clang/lib/Analysis/LifetimeSafety/Checker.cpp
+++ b/clang/lib/Analysis/LifetimeSafety/Checker.cpp
@@ -279,32 +279,28 @@ public:
// Invalidated object escapes to a field.
if (IssueExpr)
// Invalidated object on stack escapes to a field.
- SemaHelper->reportInvalidatedField(IssueExpr,
- FieldEscape->getFieldDecl(),
- Warning.InvalidatedByExpr,
- L->getAccessPath());
+ SemaHelper->reportInvalidatedField(
+ IssueExpr, FieldEscape->getFieldDecl(),
+ Warning.InvalidatedByExpr, L->getAccessPath());
else if (InvalidatedPVD)
// Invalidated parameter escapes to a field.
- SemaHelper->reportInvalidatedField(InvalidatedPVD,
- FieldEscape->getFieldDecl(),
- Warning.InvalidatedByExpr,
- L->getAccessPath());
+ SemaHelper->reportInvalidatedField(
+ InvalidatedPVD, FieldEscape->getFieldDecl(),
+ Warning.InvalidatedByExpr, L->getAccessPath());
} else if (const auto *GlobalEscape =
dyn_cast<GlobalEscapeFact>(OEF)) {
// Invalidated object escapes to global or static storage.
if (IssueExpr)
// Invalidated object on stack escapes to global or static
// storage.
- SemaHelper->reportInvalidatedGlobal(IssueExpr,
- GlobalEscape->getGlobal(),
- Warning.InvalidatedByExpr,
- L->getAccessPath());
+ SemaHelper->reportInvalidatedGlobal(
+ IssueExpr, GlobalEscape->getGlobal(),
+ Warning.InvalidatedByExpr, L->getAccessPath());
else if (InvalidatedPVD)
// Invalidated parameter escapes to global or static storage.
- SemaHelper->reportInvalidatedGlobal(InvalidatedPVD,
- GlobalEscape->getGlobal(),
- Warning.InvalidatedByExpr,
- L->getAccessPath());
+ SemaHelper->reportInvalidatedGlobal(
+ InvalidatedPVD, GlobalEscape->getGlobal(),
+ Warning.InvalidatedByExpr, L->getAccessPath());
} else if (isa<ReturnEscapeFact>(OEF)) {
// FIXME: Diagnose invalidated return escapes separately.
} else
``````````
</details>
https://github.com/llvm/llvm-project/pull/204900
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
