iitianpushkar wrote:

> Thanks, looks much better. Another suggestion for naming: I think you should 
> rename `DiagSubject` to something more specialized in each report function.

OK! I will update it in the next patch commit, once i get clarification on full 
text diagnostic notes in the tests.
Thanks.

https://github.com/llvm/llvm-project/pull/204900
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to