AbdallahRashed wrote:

> > Regarding the remaining 15 new tests in neon/intrinsics.c: the original 
> > neon-intrinsics.c had zero f32 standard rounding tests (vrnd_f32, 
> > vrnda_f32). The new file adds them for the first time.
> 
> Great, thank you so much for adding those! Now, could you also document this 
> non-obvious change in the summary? Something along the following lines would 
> be great:
> 
> > Prior to this patch, tests for the following builtins were missing:
> > 
> > * item 1
> > * item 2
> > * etc
> > 
> > For this reasons, #num-of-new-tests > #num-of-deleted-tests.
> 
> Thank you!

Done, Thank you

https://github.com/llvm/llvm-project/pull/195021
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to