================
@@ -1705,16 +1705,21 @@ class CIRGenFunction : public CIRGenTypeCache {
void instantiateIndirectGotoBlock();
- /// Emit a simple LLVM intrinsic that takes N scalar arguments and whose
- /// return type matches the type of the first argument. The intrinsic name is
- /// used verbatim; any overload mangling (e.g. `.f32`, `.p1`) must be baked
- /// into \p intrinName by the caller.
+ /// Emit a simple LLVM intrinsic that takes N scalar arguments. The
intrinsic
+ /// name is used verbatim; any overload mangling (e.g. `.f32`, `.p1`) must be
+ /// baked into \p intrinName by the caller. The result type defaults to the
+ /// type of the first argument; pass \p resultType for intrinsics whose
result
+ /// differs from the operand, such as a vector reduction that returns the
+ /// element type. Unlike classic CodeGen, CIR has no intrinsic registry to
+ /// derive the result type from the operand, so it must be supplied here.
template <unsigned N>
[[maybe_unused]] RValue
emitBuiltinWithOneOverloadedType(const CallExpr *e,
- llvm::StringRef intrinName) {
+ llvm::StringRef intrinName,
+ mlir::Type resultType = {}) {
----------------
erichkeane wrote:
I think you're missing something, or I am. Before your change, this emits
`convertType(e->getArg(0)->getType())`.
AFTER your change, you're doing the exact same thing, result type is :
`cast<cir::VectorType>(convertType(e->getArg(0)->getType()))`
that is the SAME type. The cast there is irrelevant, since you're immediately
assigning it to mlir::Type.
The above you are saying above as far as I can tell is completely inaccurate.
https://github.com/llvm/llvm-project/pull/201164
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
