================ @@ -26,6 +26,12 @@ class CIR_I64EnumAttr<string name, string summary, list<I64EnumAttrCase> cases> let cppNamespace = "::cir"; } +class CIR_I32BitEnumAttr<string name, string summary, ---------------- erichkeane wrote:
I messed with it for a few minutes, I don't think we want to change anything about this. All of the mlir `EnumAttr` types require that you specify the dialect everywhere when inheriting from it, which seems inappropriately heavy and at risk of being screwed up. The namespace added makes it unnecessary to add everywhere, and this is effectively just an alias for it with 1 fewer argument, so IMO this is worth doing/leaving alone. https://github.com/llvm/llvm-project/pull/205941 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
