https://github.com/ilovepi commented:
This is some improvement, but I'm still a bit luke warm on this approach. One thing that would help is if there was some documentation about how the nodes and hierarchy works, as well as some indication of why they represent in the Markdown. The testing is really just pro forma, as it mostly just exercises constructors and generally doesn't try to build any AST at all. I'm increasingly concerned that basic operations of the AST are just being pushed into the parser and there is no plan to build or test the requisite functionality at all. I'm going to step back from this for now and defer to @evelez7 and @petrhosek about what needs to happen to merge this PR. This can land once they're satisfied. https://github.com/llvm/llvm-project/pull/205609 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
