Sirraide wrote: > If using the visitor is what we're always supposed to do in such situations, > then sure, I can drop this patch.
Yeah, I feel like if you have to use a visitor, it’s better to use (D)RAV rather than hand-rolling your own. I’m just worried about the possibility of us encountering weird constructs that have substatements that aren’t part of `children()` (because there’s quite a bit of code in the RAV implementation to do visitation of statements in addition to iterating over `children()`...) https://github.com/llvm/llvm-project/pull/206715 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
