================ ---------------- erichkeane wrote:
Should we consider removing 'Invalid' from here all the time? It looks like this just changes our level of "how much we pretend this is close-enough-to-good-in-the-face-of-invalid" and only by a little amount? Either th is function should just remove `Invalid` completely or commit to it, WDYT? I personally like the idea of setting the AST nodes invalid (as we do for the few other cases in here, see ~2308), but it at least feels wrong that we're mixing/matching. The advantage to trying to keep a 'correct-ish' invalid one around is cascading diagnostics are potentially nicer looking. https://github.com/llvm/llvm-project/pull/207068 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
