xazax.hun added inline comments.

================
Comment at: lib/AST/ASTImporter.cpp:5549
+  Expr *BaseE = Importer.Import(E->getBase());
+  if (!BaseE)
+    return nullptr;
----------------
Does `E->getBase()` guaranteed to return non-null? What happens when this node 
was constructed using EmptyShell? Shouldn't we check for that somehow? When can 
that happen?


https://reviews.llvm.org/D38843



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to