llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-tools-extra Author: Neil Nair (Neil-N4) <details> <summary>Changes</summary> Removes the need for PARTIAL_SOURCES_INTENDED by giving clangDocMarkdown its own directory. Addresses post-merge feedback on #<!-- -->205609. --- Full diff: https://github.com/llvm/llvm-project/pull/207856.diff 6 Files Affected: - (modified) clang-tools-extra/clang-doc/CMakeLists.txt (+1) - (added) clang-tools-extra/clang-doc/markdown/CMakeLists.txt (+7) - (renamed) clang-tools-extra/clang-doc/markdown/Markdown.cpp () - (renamed) clang-tools-extra/clang-doc/markdown/Markdown.h (+3-3) - (modified) clang-tools-extra/clang-doc/support/CMakeLists.txt (-7) - (modified) clang-tools-extra/unittests/clang-doc/MarkdownParserTest.cpp (+1-1) ``````````diff diff --git a/clang-tools-extra/clang-doc/CMakeLists.txt b/clang-tools-extra/clang-doc/CMakeLists.txt index 22e2c8159e9f6..438888c1e5e13 100644 --- a/clang-tools-extra/clang-doc/CMakeLists.txt +++ b/clang-tools-extra/clang-doc/CMakeLists.txt @@ -4,6 +4,7 @@ set(LLVM_LINK_COMPONENTS FrontendOpenMP ) add_subdirectory(support) +add_subdirectory(markdown) add_clang_library(clangDoc STATIC BitcodeReader.cpp diff --git a/clang-tools-extra/clang-doc/markdown/CMakeLists.txt b/clang-tools-extra/clang-doc/markdown/CMakeLists.txt new file mode 100644 index 0000000000000..11e6958e2e828 --- /dev/null +++ b/clang-tools-extra/clang-doc/markdown/CMakeLists.txt @@ -0,0 +1,7 @@ +set(LLVM_LINK_COMPONENTS + Support + ) + +add_clang_library(clangDocMarkdown STATIC + Markdown.cpp + ) diff --git a/clang-tools-extra/clang-doc/support/Markdown.cpp b/clang-tools-extra/clang-doc/markdown/Markdown.cpp similarity index 100% rename from clang-tools-extra/clang-doc/support/Markdown.cpp rename to clang-tools-extra/clang-doc/markdown/Markdown.cpp diff --git a/clang-tools-extra/clang-doc/support/Markdown.h b/clang-tools-extra/clang-doc/markdown/Markdown.h similarity index 98% rename from clang-tools-extra/clang-doc/support/Markdown.h rename to clang-tools-extra/clang-doc/markdown/Markdown.h index f92624bac7c86..39c37cec9a774 100644 --- a/clang-tools-extra/clang-doc/support/Markdown.h +++ b/clang-tools-extra/clang-doc/markdown/Markdown.h @@ -15,8 +15,8 @@ /// //===----------------------------------------------------------------------===// -#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_DOC_SUPPORT_MARKDOWN_H -#define LLVM_CLANG_TOOLS_EXTRA_CLANG_DOC_SUPPORT_MARKDOWN_H +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_DOC_MARKDOWN_MARKDOWN_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANG_DOC_MARKDOWN_MARKDOWN_H #include "llvm/ADT/StringRef.h" #include "llvm/ADT/simple_ilist.h" @@ -312,4 +312,4 @@ class DocumentNode : public BlockNode { } // namespace clang::doc::markdown -#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_DOC_SUPPORT_MARKDOWN_H +#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_DOC_MARKDOWN_MARKDOWN_H diff --git a/clang-tools-extra/clang-doc/support/CMakeLists.txt b/clang-tools-extra/clang-doc/support/CMakeLists.txt index 2ea459b8a9404..8ac913ffbe998 100644 --- a/clang-tools-extra/clang-doc/support/CMakeLists.txt +++ b/clang-tools-extra/clang-doc/support/CMakeLists.txt @@ -5,13 +5,6 @@ set(LLVM_LINK_COMPONENTS ) add_clang_library(clangDocSupport STATIC - PARTIAL_SOURCES_INTENDED File.cpp Utils.cpp ) - -add_clang_library(clangDocMarkdown STATIC - PARTIAL_SOURCES_INTENDED - Markdown.cpp - ) - \ No newline at end of file diff --git a/clang-tools-extra/unittests/clang-doc/MarkdownParserTest.cpp b/clang-tools-extra/unittests/clang-doc/MarkdownParserTest.cpp index 01fbdbbba9bb9..3bc3dfd852f3e 100644 --- a/clang-tools-extra/unittests/clang-doc/MarkdownParserTest.cpp +++ b/clang-tools-extra/unittests/clang-doc/MarkdownParserTest.cpp @@ -6,7 +6,7 @@ // //===----------------------------------------------------------------------===// -#include "support/Markdown.h" +#include "markdown/Markdown.h" #include "gtest/gtest.h" using namespace clang::doc::markdown; `````````` </details> https://github.com/llvm/llvm-project/pull/207856 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
