mstorsjo wrote: This change breaks building Harfbuzz.
Harfbuzz internally enables a bunch of diagnostics as errors, see https://github.com/harfbuzz/harfbuzz/blob/14.2.1/src/hb.hh#L93. Previously there were no warnings at all, but now this triggers a bunch of errors: ``` [1/242] Compiling C++ object src/libharfbuzz.so.0.61421.0.p/hb-common.cc.o FAILED: src/libharfbuzz.so.0.61421.0.p/hb-common.cc.o clang++ -Isrc/libharfbuzz.so.0.61421.0.p -Isrc -I../src -I. -I.. -I/usr/include/freetype2 -I/usr/include/libpng16 -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -fno-exceptions -std=c++11 -O2 -g -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -DHAVE_CONFIG_H -fPIC -pthread -MD -MQ src/libharfbuzz.so.0.61421.0.p/hb-common.cc.o -MF src/libharfbuzz.so.0.61421.0.p/hb-common.cc.o.d -o src/libharfbuzz.so.0.61421.0.p/hb-common.cc.o -c ../src/hb-common.cc In file included from ../src/hb-common.cc:29: In file included from ../src/hb.hh:561: ../src/hb-meta.hh:131:3: error: unused function template 'operator()' [-Werror,-Wunused-template] 131 | operator () (T&& v) const HB_AUTO_RETURN (std::forward<T> (v)) | ^~~~~~~~ ``` To reproduce, clone https://github.com/harfbuzz/harfbuzz, and configure and build it like this: ``` $ git clone https://github.com/harfbuzz/harfbuzz $ cd harfbuzz $ mkdir build $ cd build $ CC=clang CXX=clang++ meson setup .. $ ninja [hit error] ``` https://github.com/llvm/llvm-project/pull/208001 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
