sihuan wrote: Thanks for working on this section. I think this still needs a few updates.
First, please add cross-project header tests in `cross-project-tests/intrinsic-header-tests/riscv_packed_simd.c`. They should cover all eight widening-convert intrinsics on both RV32 and RV64. Second, the tests should show that these intrinsics select the instructions required by the spec. The current clang test only checks generic IR (`sext`/`zext` or shuffles). The new LLVM test also checks fallback sequences, not the expected `pwcvt.*` / `pwcvtu.*` / `pwcvth.*` instructions. It looks like the backend still needs patterns for these IR forms. If those patterns are not robust enough, target intrinsics or builtins may be needed. In either case, the LLVM tests should check the spec-listed mnemonics, not the fallback expansion. https://github.com/llvm/llvm-project/pull/208394 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
