dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.

Content-wise, LGTM. There is a style nit inline.

Also, can you avoid reformatting the lines that haven't changed? This will help 
preserve the history of the file and make it clear what changes are related to 
your intended change in functionality.



================
Comment at: lib/Analysis/AnalysisDeclContext.cpp:308
+BodyFarm *AnalysisDeclContextManager::getBodyFarm() {
+  if (BdyFrm == nullptr)
+    BdyFrm = new BodyFarm(ASTCtx, Injector.get());
----------------
Nit: Style-wise this is idiomatically written as:
```
if (!BdyFrm)
```


https://reviews.llvm.org/D39208



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to