https://github.com/steakhal commented:
This was a greta patch to read. Nicely scoped, well written. LLVM conventions all the way. I had some tiny minor comments sprinkled, and I suggested some patches in my earlier comment of which some parts should semantically be here - for example, the bug reporter visitor for highlighting when the destructor runs (the closing curly). It might be also valuable to highlight the declaration of the variable because that and the curly influences - bounds - the lifetime of the object. https://github.com/llvm/llvm-project/pull/206460 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
