llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) <details> <summary>Changes</summary> Summary: This made some cases use the wrong triple while we are migrating to using `amdgpu` instead. Now, this might have some side-effects if someone is still trying to use `amdgcn`. Honestly, it might be best to just make CMake auto-update this if we want this to be smooth. --- Full diff: https://github.com/llvm/llvm-project/pull/209317.diff 1 Files Affected: - (modified) clang/lib/Basic/OffloadArch.cpp (+2-1) ``````````diff diff --git a/clang/lib/Basic/OffloadArch.cpp b/clang/lib/Basic/OffloadArch.cpp index 5d12f257f3680..d7e5e5470f886 100644 --- a/clang/lib/Basic/OffloadArch.cpp +++ b/clang/lib/Basic/OffloadArch.cpp @@ -173,7 +173,8 @@ llvm::Triple OffloadArchToTriple(const llvm::Triple &DefaultToolchainTriple, } if (IsAMDOffloadArch(ID)) - return llvm::Triple("amdgcn-amd-amdhsa"); + return llvm::Triple(llvm::Triple::amdgpu, llvm::Triple::NoSubArch, + llvm::Triple::AMD, llvm::Triple::AMDHSA); return {}; } `````````` </details> https://github.com/llvm/llvm-project/pull/209317 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
