================
@@ -473,9 +473,17 @@ fatbinary(ArrayRef<std::tuple<StringRef, StringRef, 
StringRef>> InputFiles,
   SmallVector<StringRef> Targets = {
       Saver.save("-targets=host-" + HostTriple.normalize())};
   for (const auto &[File, TripleRef, Arch] : InputFiles) {
+    llvm::Triple T(TripleRef);
+    // SPIR-V HIP targets (e.g. chipStar) can arrive without an arch, but the
+    // offload bundler requires a non-empty arch field; default to the
+    // canonical SPIR-V CPU model "generic".
----------------
linehill wrote:

IIUC by the comment, the bundler requires a CPU/GPU model no matter the target 
so I think HIPSPV toolchain/clang driver should set it (to a default value when 
not specified by users).


https://github.com/llvm/llvm-project/pull/206910
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to