https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/209740
Submit test that already exists in the rocm fork. This stresses the error cases when using the legacy OpenMP -march target specifier, which appears to be missing upstream. >From c3e55deba0c190685c9039b1595ad2050b872233 Mon Sep 17 00:00:00 2001 From: Matt Arsenault <[email protected]> Date: Wed, 15 Jul 2026 13:57:48 +0200 Subject: [PATCH] clang: Add OpenMP driver test for invalid target IDs Submit test that already exists in the rocm fork. This stresses the error cases when using the legacy OpenMP -march target specifier, which appears to be missing upstream. --- clang/test/Driver/openmp-invalid-target-id.c | 129 +++++++++++++++++++ 1 file changed, 129 insertions(+) create mode 100644 clang/test/Driver/openmp-invalid-target-id.c diff --git a/clang/test/Driver/openmp-invalid-target-id.c b/clang/test/Driver/openmp-invalid-target-id.c new file mode 100644 index 0000000000000..1141291299642 --- /dev/null +++ b/clang/test/Driver/openmp-invalid-target-id.c @@ -0,0 +1,129 @@ +// REQUIRES: amdgpu-registered-target, x86-registered-target + +// +// Legacy mode (-fopenmp-targets,-Xopenmp-target,-march) tests for TargetID +// +// RUN: not %clang -### -target x86_64-linux-gnu -fopenmp\ +// RUN: -fopenmp-targets=amdgcn-amd-amdhsa,amdgcn-amd-amdhsa \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx908 \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx908xnack \ +// RUN: %s 2>&1 | FileCheck -check-prefix=NOPLUS-L %s + +// NOPLUS-L: error: invalid target ID 'gfx908xnack' + +// RUN: not %clang -### -target x86_64-linux-gnu -fopenmp\ +// RUN: -fopenmp-targets=amdgcn-amd-amdhsa,amdgcn-amd-amdhsa \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx900 \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx908:xnack+:xnack+ \ +// RUN: %s 2>&1 | FileCheck -check-prefix=ORDER-L %s + +// ORDER-L: error: invalid target ID 'gfx908:xnack+:xnack+' + +// RUN: not %clang -### -target x86_64-linux-gnu -fopenmp\ +// RUN: -fopenmp-targets=amdgcn-amd-amdhsa,amdgcn-amd-amdhsa,amdgcn-amd-amdhsa,amdgcn-amd-amdhsa \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx908 \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx908:unknown+ \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx908+sramecc+unknown \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx900+xnack \ +// RUN: %s 2>&1 | FileCheck -check-prefix=UNK-L %s + +// UNK-L: error: invalid target ID 'gfx900+xnack' + +// RUN: not %clang -### -target x86_64-linux-gnu -fopenmp\ +// RUN: -fopenmp-targets=amdgcn-amd-amdhsa,amdgcn-amd-amdhsa,amdgcn-amd-amdhsa \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx908 \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx908:sramecc+:unknown+ \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx900+xnack \ +// RUN: %s 2>&1 | FileCheck -check-prefix=MIXED-L %s + +// MIXED-L: error: invalid target ID 'gfx900+xnack' + +// RUN: not %clang -### -target x86_64-linux-gnu -fopenmp\ +// RUN: -fopenmp-targets=amdgcn-amd-amdhsa,amdgcn-amd-amdhsa \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx908 \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx900:sramecc+ \ +// RUN: %s 2>&1 | FileCheck -check-prefix=UNSUP-L %s + +// UNSUP-L: error: invalid target ID 'gfx900:sramecc+' + +// RUN: not %clang -### -target x86_64-linux-gnu -fopenmp\ +// RUN: -fopenmp-targets=amdgcn-amd-amdhsa,amdgcn-amd-amdhsa \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx908 \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx900:xnack \ +// RUN: %s 2>&1 | FileCheck -check-prefix=NOSIGN-L %s + +// NOSIGN-L: error: invalid target ID 'gfx900:xnack' + +// RUN: not %clang -### -target x86_64-linux-gnu -fopenmp\ +// RUN: -fopenmp-targets=amdgcn-amd-amdhsa,amdgcn-amd-amdhsa \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx908 \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx900+xnack \ +// RUN: %s 2>&1 | FileCheck -check-prefix=NOCOLON-L %s + +// NOCOLON-L: error: invalid target ID 'gfx900+xnack' + +// Two legacy -Xopenmp-target -march values sharing the same triple are +// deduplicated, so no offload arch combination conflict is diagnosed here; the +// --offload-arch COMBO case below covers that diagnostic. + +// +// Offload-arch mode (--offload-arch) tests for TargetID +// +// RUN: not %clang -### -target x86_64-linux-gnu \ +// RUN: -fopenmp --offload-arch=gfx908 \ +// RUN: --offload-arch=gfx908xnack \ +// RUN: %s 2>&1 | FileCheck -check-prefix=NOPLUS %s + +// NOPLUS: error: failed to deduce triple for target architecture 'gfx908xnack' + +// RUN: not %clang -### -target x86_64-linux-gnu \ +// RUN: -fopenmp --offload-arch=gfx900 \ +// RUN: --offload-arch=gfx908:xnack+:xnack+ \ +// RUN: %s 2>&1 | FileCheck -check-prefix=ORDER %s + +// ORDER: error: invalid target ID 'gfx908:xnack+:xnack+' + +// RUN: not %clang -### -target x86_64-linux-gnu \ +// RUN: -fopenmp --offload-arch=gfx908 \ +// RUN: --offload-arch=gfx908:unknown+ \ +// RUN: --offload-arch=gfx908+sramecc+unknown \ +// RUN: --offload-arch=gfx900+xnack \ +// RUN: %s 2>&1 | FileCheck -check-prefix=UNK %s + +// UNK: error: failed to deduce triple for target architecture 'gfx900+xnack' + +// RUN: not %clang -### -target x86_64-linux-gnu \ +// RUN: -fopenmp --offload-arch=gfx908 \ +// RUN: --offload-arch=gfx908:sramecc+:unknown+ \ +// RUN: --offload-arch=gfx900+xnack \ +// RUN: %s 2>&1 | FileCheck -check-prefix=MIXED %s + +// MIXED: error: failed to deduce triple for target architecture 'gfx900+xnack' + +// RUN: not %clang -### -target x86_64-linux-gnu \ +// RUN: -fopenmp --offload-arch=gfx908 \ +// RUN: --offload-arch=gfx900:sramecc+ \ +// RUN: %s 2>&1 | FileCheck -check-prefix=UNSUP %s + +// UNSUP: error: invalid target ID 'gfx900:sramecc+' + +// RUN: not %clang -### -target x86_64-linux-gnu \ +// RUN: -fopenmp --offload-arch=gfx908 \ +// RUN: --offload-arch=gfx900:xnack \ +// RUN: %s 2>&1 | FileCheck -check-prefix=NOSIGN %s + +// NOSIGN: error: invalid target ID 'gfx900:xnack' + +// RUN: not %clang -### -target x86_64-linux-gnu \ +// RUN: -fopenmp --offload-arch=gfx908 \ +// RUN: --offload-arch=gfx900+xnack \ +// RUN: %s 2>&1 | FileCheck -check-prefix=NOCOLON %s + +// NOCOLON: error: failed to deduce triple for target architecture 'gfx900+xnack' + +// RUN: not %clang -### -target x86_64-linux-gnu \ +// RUN: -fopenmp --offload-arch=gfx908 \ +// RUN: --offload-arch=gfx908:xnack+ \ +// RUN: %s 2>&1 | FileCheck -check-prefix=COMBO %s + +// COMBO: error: invalid offload arch combinations: 'gfx908' and 'gfx908:xnack+' _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
