erichkeane wrote: > > > > Just needs a release note, else this LGTM. > > > > > > > > > [22ca91c](https://github.com/llvm/llvm-project/commit/22ca91ce27af31f579a8a770a4d584f47bcc607f) > > > (PR #127924) introduced the crash and landed a week ago on the dev > > > branch. The new diagnostic didn't ship yet. Should we still add 'crash > > > fix' to release notes or rather skip it? > > > > > > A "week ago" is still old enough to have made it into the 23.0 branch! So > > we still need a release note HERE, but we probably also want to cherry-pick > > this to the release branch. > > If we're cherry-picking to the release branch, no need for the release note > at all, right? Clang 22.x is fine today and Clang 23.x will be fine after the > cherry-pick, so Clang 24.x (main branch) doesn't need a note either?
Oh, right! For some reason I thought we were already 23.1. Yep, @patrykstefanski : Please remove teh release note now (sorry!), and feel free to merge once CI agrees. After that, you/we can do the cherry-pick. https://github.com/llvm/llvm-project/pull/210151 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
