https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/212451
Make sure -march and -mcpu both error for nonoffload and for -Xopenmp-target arguments. Defends against regression I almost introduced. >From aec0ee3e9d2d1a062e6c590b2ec92a7effd1f166 Mon Sep 17 00:00:00 2001 From: Matt Arsenault <[email protected]> Date: Tue, 28 Jul 2026 12:07:11 +0200 Subject: [PATCH] clang/AMDGPU: Add missing driver tests for invalid target names Make sure -march and -mcpu both error for nonoffload and for -Xopenmp-target arguments. Defends against regression I almost introduced. --- clang/test/Driver/invalid-target-id.cl | 4 ++++ clang/test/Driver/openmp-invalid-target-id.c | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/clang/test/Driver/invalid-target-id.cl b/clang/test/Driver/invalid-target-id.cl index f93e618e460be..57b4574814886 100644 --- a/clang/test/Driver/invalid-target-id.cl +++ b/clang/test/Driver/invalid-target-id.cl @@ -2,6 +2,10 @@ // RUN: -mcpu=gfx908xnack -nostdlib \ // RUN: %s 2>&1 | FileCheck -check-prefix=NOPLUS %s +// RUN: not %clang -target amdgcn-amd-amdhsa \ +// RUN: -march=gfx908xnack -nostdlib -### \ +// RUN: %s 2>&1 | FileCheck -check-prefix=NOPLUS %s + // NOPLUS: error: invalid target ID 'gfx908xnack' // RUN: not %clang -target amdgcn-amd-amdpal \ diff --git a/clang/test/Driver/openmp-invalid-target-id.c b/clang/test/Driver/openmp-invalid-target-id.c index 0b0d33b0543d8..d27b28310c8c1 100644 --- a/clang/test/Driver/openmp-invalid-target-id.c +++ b/clang/test/Driver/openmp-invalid-target-id.c @@ -9,6 +9,12 @@ // RUN: -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx908xnack \ // RUN: %s 2>&1 | FileCheck -check-prefix=NOPLUS-L %s +// RUN: not %clang -### -target x86_64-linux-gnu -fopenmp=libomp \ +// RUN: -fopenmp-targets=amdgcn-amd-amdhsa,amdgcn-amd-amdhsa \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -mcpu=gfx908 \ +// RUN: -Xopenmp-target=amdgcn-amd-amdhsa -mcpu=gfx908xnack \ +// RUN: %s 2>&1 | FileCheck -check-prefix=NOPLUS-L %s + // NOPLUS-L: error: invalid target ID 'gfx908xnack' // RUN: not %clang -### -target x86_64-linux-gnu -fopenmp=libomp \ _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
