AdityaOP007 wrote:

> Hm, I see, so `lifetime_capture_by` isn't supported for constructors, I don't 
> think we should remove that guard, it certainly isn't in the scope of this 
> PR, it would still be nice to keep the added test though. Also, I see that 
> you have some new binary file added, I think you should remove it too.

Thanks for the clarification! That makes sense. I'll restore the existing 
constructor guard and remove the constructor-specific handling so the PR stays 
focused on the original issue. I'll keep the constructor test as requested and 
remove the newly added binary file as well. Thanks for the review!

https://github.com/llvm/llvm-project/pull/212264
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to