NagyDonat wrote: @Xazax-hun Unless you are strongly opposed, I would like to merge this PR on Monday (Aug 3) in its current state (after I just renamed `getExtentIfRelevant` to `getExtentIfMayOverflow` in https://github.com/llvm/llvm-project/pull/210774/commits/ea6540861a3b6910852ecbe058e3552afcec33d0 to satisfy your concerns at https://github.com/llvm/llvm-project/pull/210774#discussion_r3630896931).
There are still two unresolved subjective differences between us at https://github.com/llvm/llvm-project/pull/210774#discussion_r3630908328 (`getValidState`) and https://github.com/llvm/llvm-project/pull/210774#discussion_r3630930390 (`providesInformationAboutInteresting`) but I think that this PR has reached the acceptable level and this review already took too long (I uploaded the first PR 7 weeks ago). I would like to move on to writing the bugfixes and then finally the actual feature improvements instead of bikeshedding function names. (Of course you can create a PR to revisit these name choices – preferably when it does not create merge conflicts – but I think there are lots of objectively way worse parts of the analyzer codebase and we could more effectively improve code quality in those areas.) https://github.com/llvm/llvm-project/pull/210774 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
