https://github.com/ayokunle321 updated https://github.com/llvm/llvm-project/pull/197399
>From 0bc78ecb20167c4b7d332971e942bef7ccab5ab7 Mon Sep 17 00:00:00 2001 From: Ayokunle Amodu <[email protected]> Date: Thu, 30 Jul 2026 12:02:20 -0400 Subject: [PATCH] add trig_preop builtin --- clang/lib/CIR/CodeGen/CIRGenBuiltinAMDGPU.cpp | 9 +++------ clang/test/CIR/CodeGenHIP/builtins-amdgcn.hip | 16 ++++++++++++++++ 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/clang/lib/CIR/CodeGen/CIRGenBuiltinAMDGPU.cpp b/clang/lib/CIR/CodeGen/CIRGenBuiltinAMDGPU.cpp index 63bc9d8b6b144..46226eed2c884 100644 --- a/clang/lib/CIR/CodeGen/CIRGenBuiltinAMDGPU.cpp +++ b/clang/lib/CIR/CodeGen/CIRGenBuiltinAMDGPU.cpp @@ -241,12 +241,9 @@ CIRGenFunction::emitAMDGPUBuiltinExpr(unsigned builtinId, mlir::ValueRange{src0, src1, src2}); } case AMDGPU::BI__builtin_amdgcn_trig_preop: - case AMDGPU::BI__builtin_amdgcn_trig_preopf: { - cgm.errorNYI(expr->getSourceRange(), - std::string("unimplemented AMDGPU builtin call: ") + - getContext().BuiltinInfo.getName(builtinId)); - return mlir::Value{}; - } + case AMDGPU::BI__builtin_amdgcn_trig_preopf: + return emitBuiltinWithOneOverloadedType<2>(expr, "amdgcn.trig.preop") + .getValue(); case AMDGPU::BI__builtin_amdgcn_rcp: case AMDGPU::BI__builtin_amdgcn_rcpf: case AMDGPU::BI__builtin_amdgcn_rcph: diff --git a/clang/test/CIR/CodeGenHIP/builtins-amdgcn.hip b/clang/test/CIR/CodeGenHIP/builtins-amdgcn.hip index 5dfc95490209b..546e851461ce4 100644 --- a/clang/test/CIR/CodeGenHIP/builtins-amdgcn.hip +++ b/clang/test/CIR/CodeGenHIP/builtins-amdgcn.hip @@ -223,3 +223,19 @@ __device__ void test_frexp_mant_f32(float* out, float a) { __device__ void test_frexp_mant_f64(double* out, double a) { *out = __builtin_amdgcn_frexp_mant(a); } + +// CIR-LABEL: @_Z19test_trig_preop_f32Pffi +// CIR: cir.call_llvm_intrinsic "amdgcn.trig.preop" {{.*}} : (!cir.float, !s32i) -> !cir.float +// LLVM: define{{.*}} void @_Z19test_trig_preop_f32Pffi +// LLVM: call{{.*}} float @llvm.amdgcn.trig.preop.f32(float %{{.+}}, i32 %{{.+}}) +__device__ void test_trig_preop_f32(float* out, float a, int b) { + *out = __builtin_amdgcn_trig_preopf(a, b); +} + +// CIR-LABEL: @_Z19test_trig_preop_f64Pddi +// CIR: cir.call_llvm_intrinsic "amdgcn.trig.preop" {{.*}} : (!cir.double, !s32i) -> !cir.double +// LLVM: define{{.*}} void @_Z19test_trig_preop_f64Pddi +// LLVM: call{{.*}} double @llvm.amdgcn.trig.preop.f64(double %{{.+}}, i32 %{{.+}}) +__device__ void test_trig_preop_f64(double* out, double a, int b) { + *out = __builtin_amdgcn_trig_preop(a, b); +} _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
