================ ---------------- abhinavgaba wrote:
Done in e96646304dd8 -- thanks for catching this. The block described the pre-attach-style codegen: four entries instead of five, the combined entry ordered before the `s2.z` one, `MEMBER_OF(N+1)` where `MEMBER_OF(N+2)` is emitted, and `PTR_AND_OBJ` on the `s1p->x`/`y` entries. It also still carried a FIXME asking for the attach-style codegen that is now in place. I updated it to the entries actually emitted (verified against the IR and the test's own CHECK lines) and dropped the FIXME. I also refreshed the comment in `foo()`, which listed a single top-level entry when there are two -- the mapped array plus its ATTACH entry, per `.offload_maptypes`. https://github.com/llvm/llvm-project/pull/210214 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
