================
@@ -76,16 +76,10 @@ static bool isUnsigned(SValBuilder &SVB, NonLoc Value) {
return T->isUnsignedIntegerType();
}
-// Evaluate the comparison Value < Threshold with the help of the custom
-// simplification algorithm defined for this checker. Return a pair of states,
-// where the first one corresponds to "value below threshold" and the second
-// corresponds to "value at or above threshold". Returns {nullptr, nullptr} in
-// the case when the evaluation fails.
-// If the optional argument CheckEquality is true, then use BO_EQ instead of
-// the default BO_LT after consistently applying the same simplification steps.
-static std::pair<ProgramStateRef, ProgramStateRef>
-compareValueToThreshold(ProgramStateRef State, NonLoc Value, NonLoc Threshold,
- SValBuilder &SVB, bool CheckEquality = false) {
+std::pair<ProgramStateRef, ProgramStateRef>
+bounds::compareValueToThreshold(ProgramStateRef State, SValBuilder &SVB,
+ NonLoc Value, NonLoc Threshold,
+ bool CheckEquality) {
----------------
NagyDonat wrote:
I reordered the parameters (bringing `SValBuilder` forward) to match the
parameter order of `checkBounds`.
https://github.com/llvm/llvm-project/pull/214540
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
