Author: Baranov Victor Date: 2026-08-07T05:04:41Z New Revision: e6566492c03c164f4cc4a0775a864c8d59d3f941
URL: https://github.com/llvm/llvm-project/commit/e6566492c03c164f4cc4a0775a864c8d59d3f941 DIFF: https://github.com/llvm/llvm-project/commit/e6566492c03c164f4cc4a0775a864c8d59d3f941.diff LOG: [clang-tidy][NFC] Apply llvm-redundant-casting check (#214024) Added: Modified: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp clang-tools-extra/clang-tidy/modernize/ReturnBracedInitListCheck.cpp clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp clang-tools-extra/clang-tidy/modernize/UseStartsEndsWithCheck.cpp clang-tools-extra/clang-tidy/objc/NSDateFormatterCheck.cpp clang-tools-extra/clang-tidy/readability/NonConstParameterCheck.cpp clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp index 072e80e20b0c5..5b319d11f84b1 100644 --- a/clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp @@ -91,7 +91,7 @@ static bool isVarPossiblyChanged(const Decl *Func, const Stmt *LoopStmt, static bool isVarThatIsPossiblyChanged(const Decl *Func, const Stmt *LoopStmt, const Stmt *Cond, ASTContext *Context) { if (const auto *DRE = dyn_cast<DeclRefExpr>(Cond)) { - if (const auto *VD = dyn_cast<ValueDecl>(DRE->getDecl())) + if (const ValueDecl *VD = DRE->getDecl()) return isVarPossiblyChanged(Func, LoopStmt, VD, Context); } else if (isa<MemberExpr, CallExpr, ObjCIvarRefExpr, ObjCPropertyRefExpr, ObjCMessageExpr>(Cond)) { diff --git a/clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp b/clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp index da86ecf6395ae..9aee285ded7ac 100644 --- a/clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp +++ b/clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp @@ -121,7 +121,7 @@ bool DeclFinderASTVisitor::VisitNamedDecl(NamedDecl *D) { /// Forward any declaration references to the actual check on the /// referenced declaration. bool DeclFinderASTVisitor::VisitDeclRefExpr(DeclRefExpr *DeclRef) { - if (auto *D = dyn_cast<NamedDecl>(DeclRef->getDecl())) + if (ValueDecl *D = DeclRef->getDecl()) return VisitNamedDecl(D); return true; } diff --git a/clang-tools-extra/clang-tidy/modernize/ReturnBracedInitListCheck.cpp b/clang-tools-extra/clang-tidy/modernize/ReturnBracedInitListCheck.cpp index aefaab3e45e5c..9dd0e00f56988 100644 --- a/clang-tools-extra/clang-tidy/modernize/ReturnBracedInitListCheck.cpp +++ b/clang-tools-extra/clang-tidy/modernize/ReturnBracedInitListCheck.cpp @@ -116,8 +116,8 @@ void ReturnBracedInitListCheck::check(const MatchFinder::MatchResult &Result) { // Make sure that the ctor arguments match the declaration. for (unsigned I = 0, NumParams = MatchedConstructExpr->getNumArgs(); I < NumParams; ++I) { - if (const auto *VD = dyn_cast<VarDecl>( - MatchedConstructExpr->getConstructor()->getParamDecl(I))) { + if (const ParmVarDecl *VD = + MatchedConstructExpr->getConstructor()->getParamDecl(I)) { const auto ArgType = MatchedConstructExpr->getArg(I)->getType(); const auto ParamType = VD->getType().getNonReferenceType(); if (ArgType.getCanonicalType().getUnqualifiedType() != diff --git a/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp b/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp index 4dc78904f8bb5..56dbac3ae44da 100644 --- a/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp +++ b/clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp @@ -68,8 +68,8 @@ matchEnableIfSpecializationImplTypename(TypeLoc TheType) { if (const auto SpecializationLoc = TheType.getAs<TemplateSpecializationTypeLoc>()) { - const auto *Specialization = - dyn_cast<TemplateSpecializationType>(SpecializationLoc.getTypePtr()); + const TemplateSpecializationType *Specialization = + SpecializationLoc.getTypePtr(); if (!Specialization) return std::nullopt; @@ -98,8 +98,8 @@ static std::optional<TemplateSpecializationTypeLoc> matchEnableIfSpecializationImplTrait(TypeLoc TheType) { if (const auto SpecializationLoc = TheType.getAs<TemplateSpecializationTypeLoc>()) { - const auto *Specialization = - dyn_cast<TemplateSpecializationType>(SpecializationLoc.getTypePtr()); + const TemplateSpecializationType *Specialization = + SpecializationLoc.getTypePtr(); if (!Specialization) return std::nullopt; diff --git a/clang-tools-extra/clang-tidy/modernize/UseStartsEndsWithCheck.cpp b/clang-tools-extra/clang-tidy/modernize/UseStartsEndsWithCheck.cpp index d8ab0fedfc112..61335d680eace 100644 --- a/clang-tools-extra/clang-tidy/modernize/UseStartsEndsWithCheck.cpp +++ b/clang-tools-extra/clang-tidy/modernize/UseStartsEndsWithCheck.cpp @@ -69,8 +69,7 @@ struct NotLengthExprForStringNode { return true; } - if (const auto *OnNode = - dyn_cast<Expr>(MemberCallNode->getImplicitObjectArgument())) { + if (const Expr *OnNode = MemberCallNode->getImplicitObjectArgument()) { return !utils::areStatementsIdentical(OnNode->IgnoreParenImpCasts(), ExprNode->IgnoreParenImpCasts(), *Context); diff --git a/clang-tools-extra/clang-tidy/objc/NSDateFormatterCheck.cpp b/clang-tools-extra/clang-tidy/objc/NSDateFormatterCheck.cpp index 7551afea1c0c6..5be5d6daca23e 100644 --- a/clang-tools-extra/clang-tidy/objc/NSDateFormatterCheck.cpp +++ b/clang-tools-extra/clang-tidy/objc/NSDateFormatterCheck.cpp @@ -48,7 +48,7 @@ static bool isValidDatePattern(StringRef Pattern) { void NSDateFormatterCheck::check(const MatchFinder::MatchResult &Result) { // Callback implementation. const auto *StrExpr = Result.Nodes.getNodeAs<ObjCStringLiteral>("str_lit"); - const StringLiteral *SL = cast<ObjCStringLiteral>(StrExpr)->getString(); + const StringLiteral *SL = StrExpr->getString(); const StringRef SR = SL->getString(); if (!isValidDatePattern(SR)) diff --git a/clang-tools-extra/clang-tidy/readability/NonConstParameterCheck.cpp b/clang-tools-extra/clang-tidy/readability/NonConstParameterCheck.cpp index 4cc72bb14917a..4bfe816fd6004 100644 --- a/clang-tools-extra/clang-tidy/readability/NonConstParameterCheck.cpp +++ b/clang-tools-extra/clang-tidy/readability/NonConstParameterCheck.cpp @@ -283,7 +283,7 @@ void NonConstParameterCheck::markCanNotBeConst(const Expr *E, } else if (const auto *Constr = dyn_cast<CXXConstructExpr>(E)) { for (const auto *Arg : Constr->arguments()) if (const auto *M = dyn_cast<MaterializeTemporaryExpr>(Arg)) - markCanNotBeConst(cast<Expr>(M->getSubExpr()), CanNotBeConst); + markCanNotBeConst(M->getSubExpr(), CanNotBeConst); else markCanNotBeConst(Arg, CanNotBeConst); } else if (const auto *CE = dyn_cast<CXXUnresolvedConstructExpr>(E)) { diff --git a/clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp b/clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp index 058711a570e8a..d0a6e9af4fab6 100644 --- a/clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp +++ b/clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp @@ -107,10 +107,10 @@ static const NamedDecl *getFailureForNamedDecl(const NamedDecl *ND) { if (const auto *Method = dyn_cast<CXXMethodDecl>(ND)) { if (const CXXMethodDecl *Overridden = getOverrideMethod(Method)) - Canonical = cast<NamedDecl>(Overridden->getCanonicalDecl()); + Canonical = Overridden->getCanonicalDecl(); else if (const FunctionTemplateDecl *Primary = Method->getPrimaryTemplate()) if (const FunctionDecl *TemplatedDecl = Primary->getTemplatedDecl()) - Canonical = cast<NamedDecl>(TemplatedDecl->getCanonicalDecl()); + Canonical = TemplatedDecl->getCanonicalDecl(); if (Canonical != ND) return Canonical; @@ -351,9 +351,8 @@ class RenamerClangTidyVisitor if (!Decl) return true; - if (const auto *ClassDecl = dyn_cast<TemplateDecl>(Decl)) - if (const NamedDecl *TemplDecl = ClassDecl->getTemplatedDecl()) - Check->addUsage(TemplDecl, Loc.getTemplateNameLoc(), SM); + if (const NamedDecl *TemplDecl = Decl->getTemplatedDecl()) + Check->addUsage(TemplDecl, Loc.getTemplateNameLoc(), SM); return true; } _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
