================ @@ -0,0 +1,11 @@ +// Host-side compilation on x86 (no errors expected). +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -aux-triple nvptx64 -fopenmp -x c -fsyntax-only -verify=host %s + +// Device-side compilation for targets without 128-bit float/complex support (no errors expected). ---------------- AaronBallman wrote:
Looking at some of the comments in `checkTypeSupport` leaves me a bit terrified: https://github.com/llvm/llvm-project/blob/9ff674efdb2be183f8a873f70726107b1399d708/clang/lib/Sema/Sema.cpp#L2272 Unused declaration... during codegen... turning into a bucket of bytes with some hope sprinkled in. :-D tl;dr specific to this PR: if the type is not supported on the device, we need test coverage demonstrating that problematic uses of the type are diagnosed correctly for device compilations. Can someone point me to that existing coverage? (And do we have coverage for Cuda, SYCL, OpenMP, and others? Or only one offloading language?) The changes in this PR are just adding one more case to an existing pattern, so that seems fine, but I want to make sure this isn't cargo culting around a bigger problem. https://github.com/llvm/llvm-project/pull/214497 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
