ioeric added a comment.
Code looks good with some nits.
================
Comment at: lib/Tooling/Refactoring/CMakeLists.txt:7
AtomicChange.cpp
Extract.cpp
+ SourceExtraction.cpp
----------------
Shall we move function extraction sources into a sub-directory? Like what you
did for headers.
================
Comment at: lib/Tooling/Refactoring/SourceExtraction.h:25
+/// Determines which semicolons should be inserted during extraction.
+struct ExtractionSemicolonPolicy {
+ bool IsNeededInExtractedFunction;
----------------
I think this should be a `class` with accessors if the members are not expected
to be changed by users.
================
Comment at: lib/Tooling/Refactoring/SourceExtraction.h:36
+
+private:
+ static ExtractionSemicolonPolicy neededInExtractedFunction() {
----------------
Either move these helpers into the cpp file or simply make them public.
Repository:
rL LLVM
https://reviews.llvm.org/D39441
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
