================ @@ -7,9 +7,13 @@ Finds virtual classes whose destructor is neither public and virtual nor protected and non-virtual. A virtual class's destructor should be specified in one of these ways to prevent undefined behavior. -This check implements +This check implements the first enforcement rule of ---------------- zeyi2 wrote:
IMO this still seems to overstate the check's coverage slightly (e.g. the matcher explicitly excludes final classes even when they have virtual functions and a public non-virtual destructor). Could we clarify that this applies only to non-final classes? https://github.com/llvm/llvm-project/pull/214659 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
