rorth wrote:

> We use `UNSUPPORTED: systme-windows` in some clang/test/Driver tests where 
> the windows portability becomes tedious...

I see.  However, we can do better, I believe: `lit` already has the 
`use_normalized_slashes` parameter.  How about applying it to the 
`clang/test/Driver` tests by default?  Besides, there's also 
`LLVM_WINDOWS_PREFER_FORWARD_SLASH` which could do the trick.  Alternatively, 
one could add a hidden option to `clang` that enables that normalization and 
add it to `%clang` etc.  Anything would be better than what we have now, 
especially since the current solutions are ad-hoc (either using the 
`[[SEP:/|\\\\]]` method I've applied for every affected test, or, even worse, 
use `[[/|\\\\]]` literally for the directory separator.  What makes things even 
worse is that it usually takes several iterations through the CI to handle all 
affected places.  IMO that's a total nightmare and places a serious onus on 
most developers for a Windows quirk.


https://github.com/llvm/llvm-project/pull/212725
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to