george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.

Looks good to me.
I really don't think the test format chosen in `unix-fns.c` is a good idea, as 
it is very large, auto-generated, and tightly coupled to chosen formatting. I 
think combination of checking for warning with `clang_analyzer_eval` will be 
much better, but then maybe it's not a job for this patch.


https://reviews.llvm.org/D39691



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D39691: [analyzer... George Karpenkov via Phabricator via cfe-commits

Reply via email to