Lane0218 wrote:

> Please add a release note entry to `clang/docs/ReleaseNotes.md`.
> 
> What if parameters are actually used by the allocation function? Can you add 
> tests?
> 
> If I remember correctly, there is similar mechanism when initializing the 
> promise object. Can you handle this case as well?

Thanks, you were right that my previous approach mishandled parameters actually 
passed to the selected allocation function, so I revised the implementation, 
added tests for both allocation outcomes and promise initialization, and added 
a release note.

https://github.com/llvm/llvm-project/pull/217518
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to