================ @@ -1153,9 +1179,9 @@ CIRABIRewriteContext::rewriteCallSite(mlir::Operation *callOp, mlir::ValueRange argOperands = call.getArgOperands(); newArgs.reserve(argOperands.size()); - // Whole-struct loads replaced by direct member loads for Expand operands. - // They can only be erased once the original call (their remaining user) is - // gone, so collect them and erase the dead ones at the end. + // Whole-record loads the rewrite reads around: replaced by direct member ---------------- adams381 wrote:
That sentence was bad. I renamed `replacedWholeLoads` to `deadRecordLoads` and tried to stick with the "dead" phrasing everywhere to try and keep it clear. I've rewritten the comment to be more clear. There is a longer discussion above about the rename / clarification effort I made. https://github.com/llvm/llvm-project/pull/216499 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
