https://github.com/vbvictor requested changes to this pull request.
>From clang-tidy side, I'm against this change in current state.
Instead of small `getQualifiedNameAsString()` now there are mostly 4-lines code
chunks of code like:
```cpp
SmallString<128> Buf;
{
llvm::raw_svector_ostream OS(Buf);
ND->printQualifiedName(OS);
}
```
This to me is unnecessary code bloat that was initially solved by
`getQualifiedNameAsString()`. I'm fine if we remove `getQualifiedNameAsString`
from `Decl` and just make standalone `std::string/StringRef
getQualifiedNameAsString(Decl*)`
https://github.com/llvm/llvm-project/pull/218264
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
