================ @@ -37,6 +37,9 @@ Notes ----- + Failed-fix dumps use the Unix ``diff`` command (not ``git diff``); ensure ---------------- zeyi2 wrote:
Personally I don't think this is necessary. On Windows, `lit` already searches for `diff.exe` alongside the other required Unix tools, first through `LLVM_LIT_TOOLS_DIR/PATH` and then in Git for Windows. `LLVM_LIT_TOOLS_DIR` is also documented for this purpose, so this note would mainly apply to manual invocations outside lit. Since this script is mainly used for running test files in LLVM CI, a configuration-time sanity check with a clear diagnostic would seem more useful than documenting the dependency here. cc @vbvictor for their opinions here. https://github.com/llvm/llvm-project/pull/214681 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
