https://github.com/ilovepi requested changes to this pull request.
Like others, I'm pretty against this overall. It seems like churn for churn's sake. Additionally, I don't think this should be a monolithic patch, as its hard to review and ensure nothing is escaping relevant maintainers. For clang-doc, I'm quite opposed to this boilerplate code expansion. At the very least, we'd make a helper to encapsulate that logic, which begs the question about removing the API altogether. There's a slo a few places where I do not agree with the changed implementation, even if the end result is consistent. If you want to continue this, you may, but the clang-doc changes need to be split out. https://github.com/llvm/llvm-project/pull/218264 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
