wristow added a comment.

In https://reviews.llvm.org/D39812#919687, @spatel wrote:

> I just reviewed the gcc docs:
>  https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html
>
> "[-fassociative-math] requires that both -fno-signed-zeros and 
> -fno-trapping-math be in effect."
>
> If we want to match that behavior, I need to change this patch to light up 
> 'nsz' and the no-trapping-math function attribute.


Yes, I think we want to match that behavior.  But by "light up" 'nsz' and the 
no-trapping-math attribute, do you mean automatically turn them on when 
'-fassociative-math' is specified?  I'd think it should be the other way 
around: Suppress the effect of '-fassociative-math' unless both 
'-fno-signed-zeros' and '-fno-trapping-math' are also specified.


https://reviews.llvm.org/D39812



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to