NagyDonat wrote: After the changes in this PR, only three calls of `getNode` remain: - The definition of `makeNode` (obviously there we cannot use `makeNode` :wink:). - The creation of the root node of the `ExplodedGraph` (we cannot use `makeNode`, there is no predecessor). - One more call in [`replayWithoutInlining`](https://github.com/llvm/llvm-project/blob/e1c2a9c9242e1c50dcb26b444e66a70d36364843/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp#L2377), which is not equivalent to `makeNode` because it omits the `addPredecessor` call in the "caching out" case (when `IsNew` is false).
I could switch to using `makeNode` in `replayWithoutInlining`, because that difference (not adding a secondary ancestor to an already existing node) is probably irrelevant – I don't think that it could cause any problems. https://github.com/llvm/llvm-project/pull/218462 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
