github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- 
clang/include/clang/Driver/CommonArgs.h clang/lib/Driver/ToolChains/Clang.cpp 
clang/lib/Driver/ToolChains/CommonArgs.cpp 
clang/lib/Driver/ToolChains/Flang.cpp 
llvm/include/llvm/Frontend/Driver/CodeGenOptions.h 
llvm/lib/Frontend/Driver/CodeGenOptions.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/include/clang/Driver/CommonArgs.h 
b/clang/include/clang/Driver/CommonArgs.h
index 1e0925014..72041b4dc 100644
--- a/clang/include/clang/Driver/CommonArgs.h
+++ b/clang/include/clang/Driver/CommonArgs.h
@@ -363,7 +363,7 @@ void constructLLVMLinkCommand(Compilation &C, const Tool &T,
 } // end namespace driver
 } // end namespace clang
 
-llvm::FramePointerKind
-getFramePointerKind(const llvm::opt::ArgList &Args, const llvm::Triple 
&Triple);
+llvm::FramePointerKind getFramePointerKind(const llvm::opt::ArgList &Args,
+                                           const llvm::Triple &Triple);
 
 #endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_COMMONARGS_H
diff --git a/clang/lib/Driver/ToolChains/CommonArgs.cpp 
b/clang/lib/Driver/ToolChains/CommonArgs.cpp
index a4a760f3d..db132c1d0 100644
--- a/clang/lib/Driver/ToolChains/CommonArgs.cpp
+++ b/clang/lib/Driver/ToolChains/CommonArgs.cpp
@@ -84,9 +84,8 @@ OffloadJobsOpt tools::parseOffloadJobs(const ArgList &Args) {
   return {OffloadJobsOpt::Kind::Fixed, A, Val, unsigned(NumThreads)};
 }
 
-llvm::FramePointerKind
-getFramePointerKind(const llvm::opt::ArgList &Args,
-                    const llvm::Triple &Triple) {
+llvm::FramePointerKind getFramePointerKind(const llvm::opt::ArgList &Args,
+                                           const llvm::Triple &Triple) {
   llvm::driver::FramePointerOptions Opts;
   Opts.Optimized = tools::areOptimizationsEnabled(Args);
   Opts.InstrumentationRequiresFramePointer =
@@ -113,8 +112,7 @@ getFramePointerKind(const llvm::opt::ArgList &Args,
                   llvm::driver::FramePointerOptions::FrameChainKind::AAPCS)
             .Case("aapcs+leaf",
                   llvm::driver::FramePointerOptions::FrameChainKind::AAPCSLeaf)
-            .Default(
-                llvm::driver::FramePointerOptions::FrameChainKind::None);
+            .Default(llvm::driver::FramePointerOptions::FrameChainKind::None);
   }
 
   return llvm::driver::getFramePointerKind(Triple, Opts);
diff --git a/llvm/include/llvm/Frontend/Driver/CodeGenOptions.h 
b/llvm/include/llvm/Frontend/Driver/CodeGenOptions.h
index af58dfc02..27887e1be 100644
--- a/llvm/include/llvm/Frontend/Driver/CodeGenOptions.h
+++ b/llvm/include/llvm/Frontend/Driver/CodeGenOptions.h
@@ -13,8 +13,8 @@
 #ifndef LLVM_FRONTEND_DRIVER_CODEGENOPTIONS_H
 #define LLVM_FRONTEND_DRIVER_CODEGENOPTIONS_H
 
-#include "llvm/Support/Compiler.h"
 #include "llvm/Support/CodeGen.h"
+#include "llvm/Support/Compiler.h"
 #include <optional>
 #include <string>
 
diff --git a/llvm/lib/Frontend/Driver/CodeGenOptions.cpp 
b/llvm/lib/Frontend/Driver/CodeGenOptions.cpp
index adbd39224..b691f4b5f 100644
--- a/llvm/lib/Frontend/Driver/CodeGenOptions.cpp
+++ b/llvm/lib/Frontend/Driver/CodeGenOptions.cpp
@@ -39,8 +39,8 @@ static bool isARMEABIBareMetal(const llvm::Triple &Triple) {
   return true;
 }
 
-static bool useFramePointerForTargetByDefault(
-    const llvm::Triple &Triple, const FramePointerOptions &Opts) {
+static bool useFramePointerForTargetByDefault(const llvm::Triple &Triple,
+                                              const FramePointerOptions &Opts) 
{
   if (Opts.InstrumentationRequiresFramePointer)
     return true;
 
@@ -124,8 +124,7 @@ static bool useFramePointerForTargetByDefault(
   return true;
 }
 
-static bool useLeafFramePointerForTargetByDefault(
-    const llvm::Triple &Triple) {
+static bool useLeafFramePointerForTargetByDefault(const llvm::Triple &Triple) {
   if (Triple.isAArch64() || Triple.isPS() || Triple.isVE() ||
       (Triple.isAndroid() && !Triple.isARM()))
     return false;
@@ -174,8 +173,8 @@ static bool mustMaintainValidFrameChain(const 
FramePointerOptions &Opts,
 
 // True if a target-specific option causes -fno-omit-frame-pointer to also
 // cause frame records to be created in leaf functions.
-static bool framePointerImpliesLeafFramePointer(
-    const FramePointerOptions &Opts, const llvm::Triple &Triple) {
+static bool framePointerImpliesLeafFramePointer(const FramePointerOptions 
&Opts,
+                                                const llvm::Triple &Triple) {
   if (Triple.isARM() || Triple.isThumb()) {
     // For 32-bit Arm, the -mframe-chain=aapcs+leaf option causes the
     // -fno-omit-frame-pointer optiion to imply -mno-omit-leaf-frame-pointer,
@@ -185,9 +184,8 @@ static bool framePointerImpliesLeafFramePointer(
   return false;
 }
 
-llvm::FramePointerKind
-getFramePointerKind(const llvm::Triple &Triple,
-                    const FramePointerOptions &Opts) {
+llvm::FramePointerKind getFramePointerKind(const llvm::Triple &Triple,
+                                           const FramePointerOptions &Opts) {
   // There are four things to consider here:
   // * Should a frame record be created for non-leaf functions?
   // * Should a frame record be created for leaf functions?

``````````

</details>


https://github.com/llvm/llvm-project/pull/218870
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to