================
@@ -2677,27 +2678,33 @@ mlir::LogicalResult
CIRToLLVMAbsOpLowering::matchAndRewrite(
return mlir::success();
}
-/// Convert the `cir.func` attributes to `llvm.func` attributes.
-/// Only retain those attributes that are not constructed by
-/// `LLVMFuncOp::build`. If `filterArgAttrs` is set, also filter out
-/// argument attributes.
+/// Return true for attributes constructed by `LLVMFuncOp::build`.
+static bool shouldDropFuncAttribute(cir::FuncOp func, mlir::NamedAttribute
attr,
+ mlir::StringRef linkageAttrName) {
+ return attr.getName() == mlir::SymbolTable::getSymbolAttrName() ||
+ attr.getName() == func.getFunctionTypeAttrName() ||
+ attr.getName() == linkageAttrName ||
+ attr.getName() == func.getCallingConvAttrName() ||
+ attr.getName() == func.getDsoLocalAttrName() ||
+ attr.getName() == func.getInlineKindAttrName() ||
+ attr.getName() == func.getSideEffectAttrName() ||
+ attr.getName() == CIRDialect::getNoReturnAttrName() ||
+ attr.getName() == CIRDialect::getStrictFPAttrName() ||
+ attr.getName() == func.getAnnotationsAttrName();
+}
+
+/// Lower `cir.func` attributes for an `LLVMFuncOp` or `LLVM::AliasOp`.
+/// Drop attributes populated by the destination op builder. If
+/// `includeFunctionOnlyAttrs` is false, also omit attributes that are only
+/// valid on functions.
void CIRToLLVMFuncOpLowering::lowerFuncAttributes(
- cir::FuncOp func, bool filterArgAndResAttrs,
+ cir::FuncOp func, bool includeFunctionOnlyAttrs,
SmallVectorImpl<mlir::NamedAttribute> &result) const {
+ OpenCLFunctionMetadataLowering openCLMetadataLowering(func.getContext());
for (mlir::NamedAttribute attr : func->getAttrs()) {
- if (attr.getName() == mlir::SymbolTable::getSymbolAttrName() ||
- attr.getName() == func.getFunctionTypeAttrName() ||
- attr.getName() == getLinkageAttrNameString() ||
- attr.getName() == func.getCallingConvAttrName() ||
- attr.getName() == func.getDsoLocalAttrName() ||
- attr.getName() == func.getInlineKindAttrName() ||
- attr.getName() == func.getSideEffectAttrName() ||
- attr.getName() == CIRDialect::getNoReturnAttrName() ||
- attr.getName() == CIRDialect::getStrictFPAttrName() ||
- attr.getName() == func.getAnnotationsAttrName() ||
- (filterArgAndResAttrs &&
- (attr.getName() == func.getArgAttrsAttrName() ||
- attr.getName() == func.getResAttrsAttrName())))
+ if (shouldDropFuncAttribute(func, attr, getLinkageAttrNameString()))
----------------
Men-cotton wrote:
I would prefer to keep this as a file scope static helper. The predicate is
long and does not depend on local state, so keeping it outside the function
leaves the loop focused on the lowering flow (IMO).
https://github.com/llvm/llvm-project/pull/217835
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
