joker-eph wrote: > In general the direction LGTM, can we remove the default implementation in > `getNameAttr` and the declaration and usage of > `SymbolTable::getSymbolAttrName()`? Since the name, visibility, all should be > backed by the op, we should drop the lookup via attributes and rely on the > interface methods to resolve to the proper storage in the op. Or is that out > of scope and intended for a future patch?
I was seeing this out of scope for now, since even if they are backed by the op, relying on inherent attribute APIs looked good enough. That said I just did the update you asked, PTAL? https://github.com/llvm/llvm-project/pull/218920 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
