https://github.com/erichkeane commented:

+ @AaronBallman who was responsible for most of this :D

So the problem is Decl is the base class of basically everything in the 
compiler.  Adding this extra pointer to EVERY single Decl is really expensive.  
Which is why we had the map for the lookup.  The judgement at the time was made 
that the attributes were of low enough use that the map lookup was worth the 
extra time in comparison to the massive increase in size of a bunch of Decls.

I'm not sure that we're at a point where changing this decision is 
valid/valuable, as the size increase impacts a LOT of things, like imp-limits, 
memory use, etc.

https://github.com/llvm/llvm-project/pull/219138
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to