erichkeane wrote: > @erichkeane Thanks! will do the splitting. Mapping to your "necessary to > remove existing uses vs. the effort to remove them": > > 1. Reroute existing AST/target uses onto LowerModule: purely removing > existing uses. The pipeline already had these dependencies; I'm just sourcing > them from LowerModule instead of ASTContext, no new behavior. Small, > self-contained. > > 2. Make the facts self-contained. serialize the LangOpts/target facts > into module attributes so lowering reads the module, not the invocation (per > Andy's review, see above). This is the actual removal effort, and where the > static-local-style materialization lives. > > 3. Accept .cir as cc1 input — the new capability, on top of (1)+(2). > > > Is this is roughly what you have in mind?
I think there is a couple of different patches, yes, but I don't think it would be split up the way you have them. I think I would suggest replacing each use of ASTContext(or at least, very similar uses) in separate patches that ALSO add a single fact/small set of facts to support that change. Then when you've made it through all of the ASTContext uses removed, do 3/remove ASTContext uses. https://github.com/llvm/llvm-project/pull/219048 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
